Disable ActionControllerFlashBeforeRender check, pending rubocop/rubo…

…cop-rails#1269

.rubocop.yml

@@ -303,7 +303,7 @@ Style/SwapValues: # new in 1.1
 Style/YAMLFileRead: # new in 1.53
  Enabled: true
 Rails/ActionControllerFlashBeforeRender: # new in 2.16
- Enabled: true
+ Enabled: false
 Rails/ActionControllerTestCase: # new in 2.14
  Enabled: true
 Rails/ActionOrder: # new in 2.17

app/components/access_panels/at_the_library_component.rb

@@ -4,7 +4,7 @@ module AccessPanels
  class AtTheLibraryComponent < AccessPanels::Base
  # @return [Array<Holdings::Library>] the list of libraries with holdings for the item
  def libraries
- @document.holdings.libraries.select(&:present?)
+ @document.holdings.libraries.compact_blank
  end
 
  def render?

app/models/concerns/eds_links.rb

@@ -10,7 +10,7 @@ def eds_links
  def eds_fulltext_links
  fetch('eds_fulltext_links', []).map do |link_field|
  EdsLinks::FulltextLink.new(link_field)
- end.select(&:present?)
+ end.compact_blank
  end
 
  def eds_fulltext_links_as_searchworks_links

app/models/sfx_data.rb

@@ -91,15 +91,15 @@ def url
  end
 
  def coverage
- target_xml.xpath('.//coverage_statement').map(&:text).select(&:present?)
+ target_xml.xpath('.//coverage_statement').map(&:text).compact_blank
  end
 
  def embargo
- target_xml.xpath('.//embargo_statement').map(&:text).select(&:present?)
+ target_xml.xpath('.//embargo_statement').map(&:text).compact_blank
  end
 
  def note
- target_xml.xpath('./note').map(&:text).select(&:present?)
+ target_xml.xpath('./note').map(&:text).compact_blank
  end
 
  private

lib/holdings.rb

@@ -11,7 +11,7 @@ def initialize(items = [], mhld = [])
  end
 
  def present?
- libraries.select(&:present?).any? do |library|
+ libraries.compact_blank.any? do |library|
  library.locations.any?(&:present?)
  end
  end

spec/rails_helper.rb

@@ -56,7 +56,7 @@
 # directory. Alternatively, in the individual `*_spec.rb` files, manually
 # require only the support files necessary.
 #
-Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
+Rails.root.glob('spec/support/**/*.rb').each { |f| require f }
 
 # Checks for pending migrations and applies them before tests are run.
 # If you are not using ActiveRecord, you can remove these lines.