-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] Add display messages #2045
base: main
Are you sure you want to change the base?
Conversation
115e41a
to
f2cc353
Compare
0971822
to
0d8aa85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nitpicky questions, overall looks good to me (but also i'd be hesitant to merge myself, since i'm not very familiar with stimulus, and since there aren't screenshots and i haven't tested, though i'm sure you have/will on stage)
6329bd2
to
9ac26e8
Compare
5b1be08
to
16a5bc4
Compare
65bf0fa
to
1a9ad6a
Compare
ceab673
to
fe56ee0
Compare
fe56ee0
to
b923314
Compare
3e164aa
to
9f54785
Compare
@jcoyne I've created a specific workgroup for being able to edit these messages: sdr:argo-message-editors |
@andrewjbtw the problem is that prior to this pull request, we have given members of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get an image of what these changes look like?
@ndushay on the issue: #924 (comment) |
So unfortunately, we're going to have to put this on hold until administrative permissions are worked out, which might not be for a long time. The problem with this feature vs. other features people have admin access to is that these messages are displayed prominently on the front page for everyone and too many (100+) people would have full edit access under the current permissions scheme. The risk is low that people would abuse their access, but it's the kind of thing where it would be hard to explain why it was left open if something did happen. It's true that admin access means that many users could cause other types of problems, but I don't think any other change people can make would be displayed to all users as soon as they load Argo, and there are other permissions (like APOs) that limit the scope of what people can do. What we really need to do is rationalize permissions, which is something I'll be working on, first by mapping out the current workgroup situation. As I understand it, Argo was originally intended to be adminstrator-only, with not a large user base, which is probably why people kept getting added to the admin roles. |
[on hold until administrative permissions are worked out]
Why was this change made?
Add Home page messages. Fixes #924
How was this change tested?
Which documentation and/or configurations were updated?