Revert "Revert "Inline the render_ds_profile_header"" #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8db94ec.
mjgiarlo
reviewed
Jul 6, 2020
jcoyne
changed the title
jcoyne
force-pushed
the
revert-revert
branch
2 times, most recently
from
e64e15f to
86e80bb
Compare
jcoyne
changed the title
And fix problems the test finds
mjgiarlo
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Re-add the changes that were previously added in #2157 and reverted in #2165. Now with tests and fixes.
How was this change tested?
Test suite and tested on stage.
Which documentation and/or configurations were updated?
n/a