include aria-required in feedback form #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Jan 7, 2025
| @@ -145,6 +145,7 @@ <h2>With navigation links</h2> | |||
| class="form-control" | |||
| rows="5" | |||
| required="required" | |||
| aria-required="true" | |||
There was a problem hiding this comment.
Isn't aria-required superfluous when required is specified? It seems like aria-required should only be used for non-semantic elements. see https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-required#description
There was a problem hiding this comment.
I was under the understanding you might need both at least for older browsers but maybe it is moot. https://usability.yale.edu/web-accessibility/articles/forms
There was a problem hiding this comment.
"Older versions of HTML" is different from "older browsers" though – all our stuff is HTML5, so the required attribute should always do the same thing as aria-required, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.