Merge pull request #996 from sul-dlss/update-dependencies

Update dependencies

.rubocop_todo.yml

@@ -1,50 +1,58 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-10-24 14:06:42 UTC using RuboCop version 1.37.1.
+# on 2023-09-11 10:00:10 UTC using RuboCop version 1.56.3.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 6
+Capybara/VisibilityMatcher:
+ Exclude:
+ - 'spec/features/blacklight_customizations/layout_spec.rb'
+ - 'spec/features/canonical_urls_spec.rb'
+ - 'spec/features/feedback_form_spec.rb'
+
 # Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Lint/UselessAssignment:
  Exclude:
  - 'lib/tasks/earthworks.rake'
 
 # Offense count: 6
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
  Max: 114
 
 # Offense count: 9
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods, inherit_mode.
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
 # AllowedMethods: refine
 Metrics/BlockLength:
- Max: 181
+ Max: 169
 
 # Offense count: 2
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
  Max: 136
 
 # Offense count: 4
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
  Max: 29
 
 # Offense count: 9
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
  Max: 58
 
 # Offense count: 4
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
  Max: 29
 
 # Offense count: 7
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: as, at, by, db, id, in, io, ip, of, on, os, pp, to
+# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
  Exclude:
  - 'scripts/indexing/ogp/download.rb'
@@ -69,13 +77,6 @@ RSpec/AnyInstance:
  - 'spec/controllers/feedback_forms_controller_spec.rb'
  - 'spec/support/stub_current_user.rb'
 
-# Offense count: 6
-RSpec/Capybara/VisibilityMatcher:
- Exclude:
- - 'spec/features/blacklight_customizations/layout_spec.rb'
- - 'spec/features/canonical_urls_spec.rb'
- - 'spec/features/feedback_form_spec.rb'
-
 # Offense count: 4
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
@@ -103,21 +104,7 @@ RSpec/ExpectInHook:
  Exclude:
  - 'spec/controllers/feedback_forms_controller_spec.rb'
 
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/FactoryBot/SyntaxMethods:
- Exclude:
- - 'spec/controllers/restricted_proxy_controller_spec.rb'
- - 'spec/models/user_spec.rb'
-
-# Offense count: 1
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/FilePath:
- Exclude:
- - 'spec/features/copyright_license.rb'
-
-# Offense count: 5
+# Offense count: 9
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -129,12 +116,13 @@ RSpec/MultipleDescribes:
  - 'spec/features/feedback_form_spec.rb'
  - 'spec/features/page_title_spec.rb'
 
-# Offense count: 17
+# Offense count: 20
 RSpec/MultipleExpectations:
  Max: 6
 
 # Offense count: 14
-# Configuration parameters: IgnoreSharedExamples.
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
 RSpec/NamedSubject:
  Exclude:
  - 'spec/jobs/check_layer_job_spec.rb'
@@ -173,9 +161,8 @@ RSpec/VerifiedDoubles:
  - 'spec/controllers/feedback_forms_controller_spec.rb'
  - 'spec/controllers/restricted_proxy_controller_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: SafeAutocorrect.
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/ActionControllerFlashBeforeRender:
  Exclude:
  - 'app/controllers/feedback_forms_controller.rb'
@@ -187,13 +174,15 @@ Rails/ApplicationRecord:
  - 'app/models/user.rb'
 
 # Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle, AllowToTime.
 # SupportedStyles: strict, flexible
 Rails/Date:
  Exclude:
  - 'lib/tasks/earthworks.rake'
 
 # Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: slashes, arguments
 Rails/FilePath:
@@ -214,7 +203,7 @@ Rails/I18nLocaleTexts:
  Exclude:
  - 'app/mailers/feedback_mailer.rb'
 
-# Offense count: 6
+# Offense count: 9
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Include.
 # Include: **/Rakefile, **/*.rake
@@ -236,7 +225,7 @@ Style/ClassAndModuleChildren:
  - 'config/initializers/rack_attack.rb'
  - 'test/test_helper.rb'
 
-# Offense count: 27
+# Offense count: 29
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
  Enabled: false
@@ -255,6 +244,7 @@ Style/GlobalStdStream:
  - 'config/environments/production.rb'
 
 # Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
 Style/GuardClause:
  Exclude:
@@ -264,6 +254,7 @@ Style/GuardClause:
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowedReceivers.
+# AllowedReceivers: Thread.current
 Style/HashEachMethods:
  Exclude:
  - 'lib/tasks/earthworks.rake'
@@ -278,7 +269,7 @@ Style/MutableConstant:
 
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
  Exclude: