Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot move focus to facet category headers to open/close #1260

Closed
dbranchini opened this issue Aug 26, 2024 · 7 comments
Closed

Cannot move focus to facet category headers to open/close #1260

dbranchini opened this issue Aug 26, 2024 · 7 comments
Assignees

Comments

@dbranchini
Copy link

Add the ability to move focus to facet category headers and allow users to open/close each facet category using the keyboard.

@dbranchini dbranchini converted this from a draft issue Aug 26, 2024
@peetucket
Copy link
Member

Consider doing in geoblacklight, not in earthworks

@peetucket
Copy link
Member

peetucket commented Aug 27, 2024

Works in searchworks, so may be ok in blacklight. Look at potential overrides in geoblacklight causing an issue.

tabindex should be set to a reasonable value

could try tabindex="0", which makes the element focusable in sequential keyboard navigation after any positive tabindex values

@peetucket peetucket self-assigned this Aug 27, 2024
@peetucket
Copy link
Member

Investigating now. This seems to be occurring in the main branch of blacklight right now

@peetucket
Copy link
Member

Turns out focus is being set, it's just not visible since there is no border color when we are focused. See https://stanfordlib.slack.com/archives/C0AAK1HNY/p1724799431275469

There may be two actions needed:

  1. Set a specific color for Earthworks in the CSS
  2. Set a default color in Blacklight so other apps will at least inherit something (instead of blank)

@jcoyne
Copy link
Contributor

jcoyne commented Aug 28, 2024

I think Niqui is working on a fix in component library.

@peetucket
Copy link
Member

Needed another update...will be fixed by sul-dlss/component-library#37 when it's merged, a new release and cut, and Earthworks is updated to use the new release.

Here is how it will look (tested in localhost manually):

Image
Image

@dbranchini
Copy link
Author

Seems to be working now. Thank you!

@dbranchini dbranchini moved this from In Progress to Done in Geo Workcycles 2024 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants