ensure facet button links have a focus ring #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Aug 29, 2024
styles/accessibility.css
Outdated
| @@ -1,5 +1,5 @@ | |||
| .nav-link:focus-visible, :focus-visible { | |||
| .nav-link:focus-visible, :focus-visible, .btn:focus-visible { | |||
There was a problem hiding this comment.
Instead of this override approach, can we add this into buttons.css and use the bootstrap provided variable (e.g. --bs-btn-focus-box-shadow)?
There was a problem hiding this comment.
moved style to button.css and defined color for BS variable
peetucket
force-pushed
the
facet-button-style
branch
3 times, most recently
from
83a3595 to
2d5001d
Compare
jcoyne
approved these changes
Sep 3, 2024
|
@peetucket this needs a rebase. |
peetucket
force-pushed
the
facet-button-style
branch
from
2d5001d to
5808cf3
Compare
|
Rebased |
jcoyne
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address sul-dlss/earthworks#1260