-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add searchworks url to toolbar #1082
Conversation
} | ||
config.add_show_tools_partial :data_dictionary, partial: 'data_dictionary', if: proc { |_context, _config, options| | ||
options[:document] && options[:document].data_dictionary_download.present? | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these can now all come from geoblacklight components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't them need to be updated, not removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to me the conditional logic for when to show the tools to me looks identical in geoblacklight, and i couldn't even find the partials that are referenced here in earthworks ... so I was presuming that since earthworks is derived from geoblacklight, they don't need to be re-defined here
but i'm not 100% sure, would certainly be nice to validate with enough real data to be confident
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking core GeoBlacklight code, the ArcGIS and DataDictionary components are now included. I also see the metadata partial being added similar to the above, so including the latest GeoBlacklight code on the main branch means we no longer require the additions above. For reference: https://github.com/geoblacklight/geoblacklight/blob/main/lib/generators/geoblacklight/templates/catalog_controller.rb#L309
(@document.public? && @document.available?) || | ||
(@document.same_institution? && user_signed_in? && @document.available?) | ||
def document_available?(document = @document) | ||
super && document.available? | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of other changes made in item_map_viewer_component
...see https://stanfordlib.slack.com/archives/C0AAK1HNY/p1720731983010169
Fixes #310 and follow on from sul-dlss/searchworks_traject_indexer#1490
If searchworks url is present in solr document, render on the page.
Todo:
With link:
http://localhost:3000/catalog/stanford-dt131hw5005