-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert show to three columns #1150
Conversation
dnoneill
commented
Aug 9, 2024
•
edited
Loading
edited
9a8b5d3
to
4ca8de2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we split the georeference alert off of this? Would be easier to review just the display change, and then the added alert can come after
.help-text.viewer_protocol { | ||
display: none; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it isn't in the designs but I'm slightly worried about hiding this, if only because it makes it way easier in testing to see what viewer is actually getting rendered/what the data is supposed to be. Maybe we need to check if @dbranchini hid it intentionally, and if not if there's a way to re-add it to the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove it for now and we can add it back in if Darcy says it was purposeful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this is referring to? What did I eliminate? It probably wasn't intentional.
<div class="bi bi-info-circle-fill fs-3 me-3 align-self-center | ||
d-flex justify-content-center"></div> | ||
<div class="text-body"> | ||
<div>This map is not georeferenced.</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we don't do it everywhere, but imo it's good practice to put these strings in the locale file, at least for new content/templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the georeference alert. Making new branch.