Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hierarchical dates for opengeometadata records #1408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thatbudakguy
Copy link
Member

@thatbudakguy thatbudakguy commented Sep 12, 2024

Closes #1407

Tested by using it to reindex OGM records in stage, where you can currently see the result:

Screenshot 2024-09-12 at 15 30 49

I made one or two very small changes from the traject implementation; notably other people aren't very good at providing their index years as integers...

@jcoyne
Copy link
Contributor

jcoyne commented Sep 16, 2024

Do we have any BCE dates we need to test? Any non-Gregorian calendar dates? Would it make sense to limit the top end of the range to the max year in the corpus? Can you expand one of the years to show what it looks like unfurled?

@thatbudakguy
Copy link
Member Author

I've just reindexed all of prod and all of the OGM data and there are no BCE dates. If there are non-gregorian dates, I guess we have no way of knowing, because none of them are 4-digit integers that are obviously outside the range of gregorian dates...but I think that'd be at least somewhat of an abuse of the spec, if not outright invalid.

Re: limiting the top end to the max year, that seems like a nice change, although I'm not sure offhand how to do it and it might make the facet logic a lot more complicated.

You can see what they look like unfurled in current production, since the reindex is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hierarchical year indexing for non-Stanford content
2 participants