Only add margin to consecutive paragraphs

[thatbudakguy]

This overrides a geoblacklight style to prevent extra margin from being added to item descriptions.

Before

After

[jcoyne]

@dbranchini have you reviewed this?

@thatbudakguy which GeoBlacklight style are you referring to? Should this be changed in GBL instead?

[dbranchini]

On the surface, it looks like a good idea, but I haven't seen this working. Can I review this somewhere @thatbudakguy or maybe hop on a quick call to see it on your local instance?

[thatbudakguy]

Sure, I can deploy this to UAT. As far as I'm aware, there's only one place this can effect, which is descriptions on item pages.

It's not a GBL override because GBL doesn't actually create consecutive paragraphs; we override the presentation of the description field to render it as multiple paragraphs.

[thatbudakguy]

Deployed to UAT.

[jcoyne]

@thatbudakguy I'm confused what you're meaning when you wrote:

This overrides a geoblacklight style

but then

It's not a GBL override

Can you clarify that for me?

[thatbudakguy]

Yes, sorry – it's confusing!

There are two declarations added in this PR that work together.

/* Geoblacklight override: only add margin for consecutive paragraphs */
p {
  margin-bottom: 0;
}

This one is a Geoblacklight override, because Geoblacklight sets a global p style. However, it doesn't actually use p to render the description (it was unclear to me where, if at all, there are p in Geoblacklight, but I elected to leave it alone there).

p + p {
  margin-top: 1rem;
}

This one is not a Geoblacklight override, because only Earthworks chooses to render descriptions as consecutive p.

[jcoyne]

@thatbudakguy are you sure this isn't from Bootstrap? https://github.com/twbs/bootstrap/blob/fecd219983539aa0110a7e09d31b8aa4d5fb4348/scss/_reboot.scss#L130

[jcoyne]

My concern here is that this is very broadly scoped. Can you do this only scoped to .document-metadata p?

[thatbudakguy]

Sure, that makes sense. Updated.