Change content type back to application/json for H2 files #585
+150
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
force-pushed
the
relax_put_disk_request_check
branch
from
21e8855 to
8ce9bfc
Compare
…tent_type, reset back to application/json
peetucket
force-pushed
the
relax_put_disk_request_check
branch
from
8ce9bfc to
c6b4757
Compare
peetucket
changed the title
This was referenced Jun 9, 2023
peetucket
changed the title
jmartin-sul
approved these changes
Jun 14, 2023
Co-authored-by: Johnathan Martin <jmartin-sul@users.noreply.github.com>
jmartin-sul
requested changes
Jun 15, 2023
There was a problem hiding this comment.
thanks for the openapi.yml edit, and for rolling in the tests @edsu experimented with for reproducing the undesired 400 in #586! had a note to myself to add the former and to try doing the latter 🎉
requesting changes for a small thing: i think the openapi comment needs to be moved to the /v1/disk route. no good deed, and all that 😬
peetucket
force-pushed
the
relax_put_disk_request_check
branch
from
5d9941d to
930a199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
Part of sul-dlss/happy-heron#3075
Needs to go with sul-dlss/happy-heron#3083 and sul-dlss/sdr-client#284
Todo:
application/jsonfiles can be set to content typeapplication/x-stanford-jsonif you do not want validation to occurHow was this change tested? 🤨
On QA with H2 and added new specs here