Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Docker container #9

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Add initial Docker container #9

merged 2 commits into from
Sep 30, 2024

Conversation

edsu
Copy link
Contributor

@edsu edsu commented Sep 16, 2024

This commit adds an initial Whisper Docker container, along with a program that pulls jobs from SQS, media from S3, and then pushes results back to S3 and SQS. There are more details in the README about how it works, how to run an example, and tests.

Closes #3

This commit adds an initial Whisper Docker container, along with program
run.py that pulls job files and media from an "todo" AWS SQS and S3
bucket respectively, and writes the Whisper output back to the bucket
while placing a "done" message in another queue. See README.md for the
details.
Copy link
Member

@jmartin-sul jmartin-sul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of small questions and suggestions. the suggested docker command didn't work for me (it hung without processing any jobs or producing any output -- idk if this was a result of the env var stuff, didn't look into the issue much). but just running python speech_to_text.py --create test_video.mp4 and python speech_to_text.py to grab that one job worked for me, doing the processing directly on my laptop instead of the container, of course. i pulled the output from the S3 bucket, and it looked good! i did also add SPEECH_TO_TEXT_TODO_SQS_QUEUE and SPEECH_TO_TEXT_DONE_SQS_QUEUE values to my .env.

i think i'd be fine to merge this as-is and do follow up changes, since this is still at a pretty early stage, but fine with whatever.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
speech_to_text.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
- tightened up documentation
- removed the secret environment files from getting cooked into the image!
- added a --receive option to fetch messages off the DONE queue.
@edsu edsu merged commit 1fd0eb3 into main Sep 30, 2024
@edsu edsu deleted the docker branch September 30, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants