Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added registry for community-manager #104

Conversation

wachterjohannes
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs non
License MIT

What's in this PR?

This PR introduces a registry for the community-managers (webspace specific).

Why?

This replaces the handling of ids inside of the controller or other extensions.

@wachterjohannes wachterjohannes force-pushed the feature/community-manager-registry branch 3 times, most recently from 4c50cc7 to bd170e0 Compare August 14, 2018 13:45
@alexander-schranz
Copy link
Member

alexander-schranz commented Aug 14, 2018

Errors:

  • Class 'Symfony\Component\DependencyInjection\ChildDefinition' not found
  • Call to undefined method Symfony\Component\DependencyInjection\Definition::setArgument()

@wachterjohannes wachterjohannes force-pushed the feature/community-manager-registry branch 3 times, most recently from a1577f2 to 18259dd Compare August 14, 2018 15:25
@wachterjohannes wachterjohannes force-pushed the feature/community-manager-registry branch from 18259dd to d4e1585 Compare August 16, 2018 07:51
@alexander-schranz alexander-schranz merged commit 3365cf2 into sulu:master Aug 16, 2018
@wachterjohannes wachterjohannes deleted the feature/community-manager-registry branch August 16, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants