Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also make name in emailadresses configurable #54

Merged
merged 3 commits into from
Apr 1, 2017
Merged

Also make name in emailadresses configurable #54

merged 3 commits into from
Apr 1, 2017

Conversation

reyostallenberg
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #52
Related issues/PRs -
License MIT
Documentation PR in this PR

What's in this PR?

This PR makes it possible to also configure the name in the emails sent by the system

So instead of configuring:

sulu_community:
    webspaces:
        <webspace_name>:
            from: test@example.com
            to: test@example.com

This is also possible (and documented to do it this way):

sulu_community:
    webspaces:
        <webspace_name>:
            from: 
                name: Test
                email: test@example.com
            to: 
                name: Test
                email: test@example.com

Why?

It fixes #52 and makes e-mails sent by the system look nicer in the users inbox.

Example Usage

See above

BC Breaks/Deprecations

None

To Do

@alexander-schranz alexander-schranz merged commit 63e4d48 into sulu:develop Apr 1, 2017
@alexander-schranz
Copy link
Member

@reyostallenberg sorry for the late review. works all like expected. Thank you for your contribution!

@alexander-schranz alexander-schranz mentioned this pull request Apr 18, 2017
Merged
alexander-schranz added a commit to alexander-schranz/SuluCommunityBundle that referenced this pull request Dec 4, 2017
@alexander-schranz
Merge pull request sulu#54 from alexander-schranz/develop
94613b0 
Release: 1.0.0-RC1
alexander-schranz pushed a commit to alexander-schranz/SuluCommunityBundle that referenced this pull request Dec 4, 2017
@dominikmatt @alexander-schranz
Fixed date type default value (sulu#54)
17fba4d
alexander-schranz added a commit to alexander-schranz/SuluCommunityBundle that referenced this pull request Dec 4, 2017
@alexander-schranz
Release: 0.1.0
874935b 
# Changelog

 - FEATURE     sulu#59   Added correct composer dependencies
 - FEATURE     sulu#57    Added basic theme for dynamic forms
 - FEATURE     sulu#56    Added daterange to csv export overlay for sulu 1.5
 - BUGFIX      sulu#55    Fixed dynamic list factory with hidden fields
 - BUGFIX      sulu#54    Fixed date type default value
 - ENHANCEMENT sulu#52    Update sulu from `alexander-schranz/sulu-form-bundle` from commit `c110e72e44a58a0f53428c153e405124695506f6`
 - BUGFIX      sulu#52    Fixed form preview request analyzer
 - BUGFIX      sulu#52    Fixed second date field type
 - BUGFIX      sulu#52    Fixed missing translation and documentation
 - ENHANCEMENT sulu#52    Added missing documentation
 - BUGFIX      sulu#52    Fixed success email not sent to email in data json
 - BUGFIX      sulu#52    Fixed missing uniqueness in form fields table
 - BUGFIX      sulu#52    Fixed permission denied on fields action
 - FEATURE     sulu#52    Added toggler to set email as replyTo
 - BUGFIX      sulu#52    Fixed exception controller redirect
 - BUGFIX      sulu#52    Fixed form select by using native select
 - FEATURE     sulu#52    Added media collection strategy tree
 - FEATURE     sulu#52    Added support to add dynamic list to article bundle
 - BUGFIX      sulu#52    Fixed csv export for bool values
 - ENHANCEMENT sulu#52    Fixed sort on dynamic list and removed search
 - FEATURE     sulu#52    Added dynamic form list and export
 - FEATURE     sulu#20    Added additional receivers for sending notification as CC or BCC
 - ENHANCEMENT sulu#23    Fixed composer json links and description
 - BUGFIX      sulu#16    Fixed setting of entity value in dynamic which represents an array
 - ENHANCEMENT sulu#13    Added dynamic type pool service for enabling custom form field types
 - ENHANCEMENT sulu#10    Update sulu from `alexander-schranz/sulu-form-bundle` from commit `c16a04b15fe320c039064de05ddaef9d087dbc6f`
 - BUGFIX      sulu#10    Fixed permission problem on false locale
 - BUGFIX      sulu#10    Fixed limitation of content type select
 - FEATURE     sulu#10    Added options for attachment validation
 - BUGFIX      sulu#10    Fixed multiple choices to text type columns
 - BUGFIX      sulu#10    Fixed naming of mailchimp parameters
 - FEATURE     sulu#3     Added short title to fields
 - FEATURE     sulu#2     Changed title field for labels to texteditor
 - ENHANCEMENT #-     Updated namespaces and rename table names
 - ENHANCEMENT #-     Forked from `alexander-schranz/sulu-form-bundle` from commit `36a7cd11562ed0c9f64752b37707cc2771e0baca`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement from and to name for emails
2 participants
@reyostallenberg @alexander-schranz