Bugfix/fix for sf3 incompatibel formtype properties #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Symfony compatibility requirement in the composer.json Affected file modified: composer.json
The used option types were incompatible with Symfony 3. old -> new ------------ type -> entry_type options -> options_type property -> choice_label Affected files: modified: Form/Type/ProfileAddressType.php modified: Form/Type/ProfileContactType.php
|
No breaking changes as sulu 1.3 is required which requires atleast 2.8.7 of symfony. |
|
@nwaelkens thank you! |
nwaelkens
deleted the
bugfix/fix-for-sf3-incompatibel-formtype-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Some used options for two formfield types were not compatible with symphony 3. There are changed.
Details:
CollectionType:
typeis nowentry_typeCollectionType:
optionsis nowoptions_typeThese changes break bc with sf2.7.
See: https://symfony.com/doc/current/reference/forms/types/collection.html
EntityType:
propertyis nowchoice_labelSee: https://symfony.com/doc/current/reference/forms/types/entity.html
Added Symfony compatibility requirement in the composer.json: "symfony/symfony": "^2.8.7 || ^3.0",
Why?
UndefinedOptionsException was thrown in SF3.
BC Breaks/Deprecations
Changes break with SF2.7