Add toggler toolbar action (#67)

sulu · Mar 8, 2021 · 3cbc8b4 · 3cbc8b4
1 parent d12a4ef
commit 3cbc8b4
Show file tree

Hide file tree

Showing 6 changed files with 91 additions and 19 deletions.
diff --git a/Admin/RedirectAdmin.php b/Admin/RedirectAdmin.php
@@ -14,6 +14,7 @@
 use Sulu\Bundle\AdminBundle\Admin\Admin;
 use Sulu\Bundle\AdminBundle\Admin\Navigation\NavigationItem;
 use Sulu\Bundle\AdminBundle\Admin\Navigation\NavigationItemCollection;
+use Sulu\Bundle\AdminBundle\Admin\View\TogglerToolbarAction;
 use Sulu\Bundle\AdminBundle\Admin\View\ToolbarAction;
 use Sulu\Bundle\AdminBundle\Admin\View\ViewBuilderFactoryInterface;
 use Sulu\Bundle\AdminBundle\Admin\View\ViewCollection;
@@ -68,6 +69,12 @@ public function configureViews(ViewCollection $viewCollection): void
         $formToolbarActions = [
             new ToolbarAction('sulu_admin.save'),
             new ToolbarAction('sulu_admin.delete'),
+            new TogglerToolbarAction(
+                'sulu_redirect.enabled',
+                'enabled',
+                'enable',
+                'disable'
+            ),
         ];
 
         $listToolbarActions = [

diff --git a/Controller/RedirectRouteController.php b/Controller/RedirectRouteController.php
@@ -13,15 +13,16 @@
 
 use Doctrine\ORM\EntityManagerInterface;
 use FOS\RestBundle\Controller\Annotations\RouteResource;
-use FOS\RestBundle\Routing\ClassResourceInterface;
 use FOS\RestBundle\View\ViewHandlerInterface;
+use HandcraftedInTheAlps\RestRoutingBundle\Routing\ClassResourceInterface;
 use Sulu\Bundle\RedirectBundle\Admin\RedirectAdmin;
 use Sulu\Bundle\RedirectBundle\Manager\RedirectRouteManagerInterface;
 use Sulu\Bundle\RedirectBundle\Model\RedirectRouteInterface;
 use Sulu\Bundle\RedirectBundle\Model\RedirectRouteRepositoryInterface;
 use Sulu\Component\Rest\AbstractRestController;
 use Sulu\Component\Rest\DoctrineRestHelper;
 use Sulu\Component\Rest\Exception\EntityNotFoundException;
+use Sulu\Component\Rest\Exception\RestException;
 use Sulu\Component\Rest\ListBuilder\Doctrine\DoctrineListBuilderFactoryInterface;
 use Sulu\Component\Rest\ListBuilder\FieldDescriptorInterface;
 use Sulu\Component\Rest\ListBuilder\ListRepresentation;
@@ -77,7 +78,7 @@ public function getSecurityContext(): string
     /**
      * @var string
      */
-    protected $tagEntityName;
+    protected $redirectRouteEntityName;
 
     public function __construct(
         ViewHandlerInterface $viewHandler,
@@ -87,7 +88,7 @@ public function __construct(
         EntityManagerInterface $entityManager,
         RedirectRouteManagerInterface $redirectRouteManager,
         RedirectRouteRepositoryInterface $redirectRouteRepository,
-        string $tagEntityName
+        string $redirectRouteEntityName
     ) {
         parent::__construct($viewHandler);
         $this->restHelper = $restHelper;
@@ -96,7 +97,7 @@ public function __construct(
         $this->entityManager = $entityManager;
         $this->redirectRouteManager = $redirectRouteManager;
         $this->redirectRouteRepository = $redirectRouteRepository;
-        $this->tagEntityName = $tagEntityName;
+        $this->redirectRouteEntityName = $redirectRouteEntityName;
     }
 
     /**
@@ -108,7 +109,7 @@ public function cgetAction(Request $request)
     {
         /** @var FieldDescriptorInterface[] $fieldDescriptors */
         $fieldDescriptors = $this->fieldDescriptor->getFieldDescriptors('redirect_routes');
-        $listBuilder = $this->factory->create($this->tagEntityName);
+        $listBuilder = $this->factory->create($this->redirectRouteEntityName);
 
         $this->restHelper->initializeListBuilder($listBuilder, $fieldDescriptors);
         $results = $listBuilder->execute();
@@ -141,6 +142,42 @@ public function postAction(Request $request)
         return $this->handleView($this->view($redirectRoute));
     }
 
+    public function postTriggerAction(Request $request, string $id): Response
+    {
+        $action = $request->get('action');
+
+        /** @var RedirectRouteInterface|null $redirectRoute */
+        $redirectRoute = $this->redirectRouteRepository->find($id);
+
+        if (null === $redirectRoute) {
+            throw new EntityNotFoundException($this->redirectRouteEntityName, $id);
+        }
+
+        try {
+            switch ($action) {
+                case 'enable':
+                    $redirectRoute->setEnabled(true);
+                    $this->entityManager->flush();
+
+                    break;
+                case 'disable':
+                    $redirectRoute->setEnabled(false);
+                    $this->entityManager->flush();
+
+                    break;
+                default:
+                    throw new RestException('Unrecognized action: ' . $action);
+            }
+
+            // prepare view
+            $view = $this->view($redirectRoute, 200);
+        } catch (RestException $exception) {
+            $view = $this->view($exception->toArray(), 400);
+        }
+
+        return $this->handleView($view);
+    }
+
     /**
      * Returns single redirect-route.
      *
@@ -154,7 +191,7 @@ public function getAction($id)
     {
         $entity = $this->redirectRouteRepository->find($id);
         if (!$entity) {
-            throw new EntityNotFoundException($this->tagEntityName, $id);
+            throw new EntityNotFoundException($this->redirectRouteEntityName, $id);
         }
 
         return $this->handleView($this->view($entity));
@@ -192,7 +229,7 @@ public function deleteAction($id)
         /** @var RedirectRouteInterface|null $redirectRoute */
         $redirectRoute = $this->redirectRouteRepository->find($id);
         if (!$redirectRoute) {
-            throw new EntityNotFoundException($this->tagEntityName, $id);
+            throw new EntityNotFoundException($this->redirectRouteEntityName, $id);
         }
 
         $this->redirectRouteManager->delete($redirectRoute);

diff --git a/Resources/config/forms/redirect_route_details.xml b/Resources/config/forms/redirect_route_details.xml
@@ -6,17 +6,7 @@
     <key>redirect_route_details</key>
 
     <properties>
-        <property name="enabled" type="checkbox" colspan="2">
-            <meta>
-                <title>sulu_redirect.enabled</title>
-            </meta>
-            <params>
-                <param name="type" value="toggler"/>
-                <param name="default_value" value="true"/>
-            </params>
-        </property>
-
-        <property name="statusCode" type="single_select" colspan="10" mandatory="true">
+        <property name="statusCode" type="single_select" mandatory="true">
             <meta>
                 <title>sulu_redirect.status_code</title>
             </meta>

diff --git a/Resources/config/routing_api.yml b/Resources/config/routing_api.yml
@@ -4,3 +4,10 @@ sulu_redirect.redirect_route:
     resource: sulu_redirect.redirect_route_controller
     options:
         expose: true
+
+sulu_redirect.post_redirect-route_trigger:
+    path: /redirect-routes/{id}.{_format}
+    methods: POST
+    defaults:
+        _controller: sulu_redirect.redirect_route_controller::postTriggerAction
+        _format: json
diff --git a/Tests/Functional/Controller/RedirectRouteControllerTest.php b/Tests/Functional/Controller/RedirectRouteControllerTest.php
@@ -95,6 +95,36 @@ public function testPostWithSourceHostAlreadyExists()
         $this->assertHttpStatusCode(409, $response);
     }
 
+    public function testPostTriggerActionEnable(): void
+    {
+        $response = $this->post(array_merge($this->defaultData, ['enabled' => false]));
+        $data = json_decode($response->getContent(), true);
+
+        $this->client->request('POST', self::BASE_URL . '/' . $data['id'], [
+            'action' => 'enable',
+        ]);
+        $response = $this->client->getResponse();
+        $this->assertHttpStatusCode(200, $response);
+
+        $content = json_decode($response->getContent(), true);
+        $this->assertTrue($content['enabled']);
+    }
+
+    public function testPostTriggerActionDisable(): void
+    {
+        $response = $this->post(array_merge($this->defaultData, ['enabled' => true]));
+        $data = json_decode($response->getContent(), true);
+
+        $this->client->request('POST', self::BASE_URL . '/' . $data['id'], [
+            'action' => 'disable',
+        ]);
+        $response = $this->client->getResponse();
+        $this->assertHttpStatusCode(200, $response);
+
+        $content = json_decode($response->getContent(), true);
+        $this->assertFalse($content['enabled']);
+    }
+
     public function testGet()
     {
         $response = $this->post($this->defaultData);

diff --git a/composer.json b/composer.json
@@ -11,7 +11,8 @@
         "symfony/config": "^4.3 || ^5.0",
         "symfony/console": "^4.3 || ^5.0",
         "symfony/http-foundation": "^4.3 || ^5.0",
-        "friendsofsymfony/rest-bundle": "^2.6 || ^3.0",
+        "handcraftedinthealps/rest-routing-bundle": "^1.0",
+        "friendsofsymfony/rest-bundle": "^2.8 || ^3.0",
         "symfony/http-kernel": "^4.3 || ^5.0",
         "doctrine/orm": "^2.5.3",
         "symfony/event-dispatcher": "^4.3 || ^5.0",