Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sourceHost import #84

Merged
merged 2 commits into from Oct 19, 2022
Merged

Fix sourceHost import #84

merged 2 commits into from Oct 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #82
Related issues/PRs #82
License MIT

What's in this PR?

Fixes sourceHost import. See #82

@alexander-schranz alexander-schranz changed the title Fix: sourceHost import Fix sourceHost import Oct 19, 2022
@luca-rath
Copy link
Contributor

@flogado Thank you very much for your contribution. There was a small issue with import files without a header row, I fixed it and pushed it into your 2.1 branch. I have also added a test case.

@luca-rath luca-rath enabled auto-merge (squash) October 19, 2022 15:29
@luca-rath luca-rath merged commit 419d538 into sulu:2.1 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourceHost field is empty after import
3 participants