Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nominatim location example #781

Merged

Conversation

martinlagler
Copy link
Contributor

@martinlagler martinlagler commented Oct 13, 2023

Q A
Related PRs sulu/sulu#7172
License MIT

What's in this PR?

Fix the example code for the geolocators.

Why?

Because the API changed.

@remdan
Copy link
Contributor

remdan commented Nov 17, 2023

This is not enough...
the locate function is based on: https://nominatim.org/release-docs/develop/api/Search/
but the new api is not compatible: https://developer.mapquest.com/documentation/geocoding-api/address/get/

currently would work:

sulu_location:
  geolocator: nominatim
  geolocators:
    nominatim:
      endpoint:             'https://nominatim.openstreetmap.org/search?'

@alexander-schranz
Copy link
Member

@remdan thx for the hints do you have some background about the history of the api changes. Let move the discussion to the open pull request: https://github.com/sulu/sulu/pull/7172/files#r1410619521

@martinlagler martinlagler force-pushed the bugfix/update-location-example branch 2 times, most recently from 4395a3b to 227c099 Compare February 13, 2024 08:46
@alexander-schranz alexander-schranz changed the base branch from 2.x to 2.4 February 13, 2024 08:48
@alexander-schranz alexander-schranz merged commit c813212 into sulu:2.4 Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants