Upgrade to Symfony 2.8 #573
Conversation
Added default-template to webspace theme
Enable new persistence handling for User & Role
Cleanup config to reduce merge conflicts
danrot
force-pushed
the
feature/symfony2.8
branch
from
591c0c4 to
f2549bf
Compare
danrot
force-pushed
the
feature/symfony2.8
branch
2 times, most recently
from
919d60c to
101b31c
Compare
danrot
force-pushed
the
feature/symfony2.8
branch
from
101b31c to
2d178e6
Compare
| # 3. Uncomment next line: | ||
| # path: "%database_path%" | ||
|
|
||
| server_version: 5.6 |
There was a problem hiding this comment.
For some reason this is necessary... @cbastienbaron has tracked that down to this doctrine issue: doctrine/dbal#990
I've also found the following issue, where this solution is suggested as a workaround, until they've fixed the problem: doctrine/DoctrineBundle#351
But on the other hand it is really bad, because it couples us to a specific DB version 😞
There was a problem hiding this comment.
yep i'm not very happy with this workaround ... one solution is to downgrade doctrine/dbal to 2.4* but also doctrine/orm whitch is required on 2.5 on composer.json make conflict beetween doctrine/orm 2.5 and doctrine/dbal 2.4 😭 or downgrade too doctrine/orm to 2.4 ...
There was a problem hiding this comment.
The problem is that we upgraded to doctrine 2.5 some time ago, because doctrine 2.4 had another bug which caused problems 😕
There was a problem hiding this comment.
At least the configuration should be moved to the parameters.yml, because it is installing specific.
There was a problem hiding this comment.
yes moved to parameters.yml can be the best solution 👍 , with a default value (ex 5.1), so dev can start project without being nuts about his mysql serv version
Quotes always from doctrine/dbal#990
Well, my version is 5.5 so I originally used that. Today I tried 5 and 52 and 1 and they all worked!
so it seems that the actual_ version doesn't matter (at least when I need them, which is *before I've actually set up the DB credentials) as long is there is _some value*.
There was a problem hiding this comment.
We've decided that it's not acceptable like this... We probably at least have to introduce a parameter, which goes into paramaters.yml.dist, so that it can be set by the installation. We also have to remember to remove this afterwards. I'll add this into this PR.
|
Some tests are still failing, but I've got the feeling it was already like that before, and is not related to this upgrade. I am not sure if it's caused by the error in the preview: |
tasks:
Replaces #466
informations: