Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment marking prevents scanning after update #67

Closed
LucaDiba opened this issue Oct 12, 2021 · 1 comment
Closed

Alignment marking prevents scanning after update #67

LucaDiba opened this issue Oct 12, 2021 · 1 comment

Comments

@LucaDiba
Copy link

Hi, I'm using Awesome-qr.js on Vue (using vue-qr). I opened an issue on that repo but it seems that the problem is on Awesome-qr.js. After an update I'm not able to scan the generated QR code anymore.

The problem is the change of the alignment marking (the little square at bottom-right):
image

This is what is generated with the latest version. It's dotted and many scanning apps don't read it.
I tried to fill the space between the dots and it's possible to scan it again, so the problem is this one.

The issue seems to be the default value of the dotScale option (i see that is deprecated in this library so I'm not sure if it's still wrongly used). The default is 0.4, but if the value is changed to 1 (on vue-qr 1 is the default value), everything is scaled to 1 except from the alignment marking.

@sumimakito
Copy link
Owner

sumimakito commented Oct 12, 2021

Hello and thanks for your feedback.

In the latest version of awesome-qr on npm, the dotScale option has been marked as deprecated and will not be used in default unless the option is explicitly specified. After the inspection and testing, I found that the default values in prebuilt libraries under dist/ and lib/ differ from the ones specified in typescript files under src/. I think this might be caused by a mistake made by me while I was packing the previous version published on npm.

I've rebuilt the libraries and published a new version (v2.1.5) to npm. Hopefully, this should fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants