Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment marking prevents scanning after update to 3.1.0 #98

Closed
LucaDiba opened this issue Oct 11, 2021 · 9 comments
Closed

Alignment marking prevents scanning after update to 3.1.0 #98

LucaDiba opened this issue Oct 11, 2021 · 9 comments

Comments

@LucaDiba
Copy link

Hi, after the upgrade to 3.1.0, I'm not able to scan the generated QR code anymore.

The problem is the change of the alignment marking (the little square at bottom-right):
image

This is what is generated with the latest version. It's dotted and many scanning apps don't read it. I tried to fill the space between the dots and it's possible to scan it again, so the problem is this one.

It would be nice to have an option to have the alignment marking dotted for whatever reason, but if there is not such option I think it's better to go back to the previous version (which should also be the default one).

@Binaryify
Copy link
Owner

could you provide the params

@LucaDiba
Copy link
Author

I'm using the following code:

<vue-qr
            :text="Hello world"
            :callback="generatedQRURI"
            dotScale=1
            size=500
            style="max-width:80%"
          >

I saw that, in the README, the dotScale default value is 0.35. If I remove dotScale, however, it seems that the default value is 1. In any case, I think that the problem is that, while the dotScale of the QR code changes, the dotScale of the alignment marking is not updated (and, I think, is kept to 0.35).

@Binaryify
Copy link
Owner

I can't reproduce
image

(and the README default value I forgot update, the dotScale default is 1)

Binaryify added a commit that referenced this issue Oct 12, 2021
@LucaDiba
Copy link
Author

@Binaryify I think that the problem is that "Hello world" is too short and the alignment marking part is not even showing (I wrote "Hello world" as a placeholder, I'm sorry). Could you try with, for instance, 123456789012345 and the following code?
<vue-qr text="123456789012345"></vue-qr>

This is my result:
image

Just to be clear, these are my dependencies:

"dependencies": {
    "core-js": "^3.6.5",
    "vue": "^2.6.11",
    "vue-qr": "^3.1.0"
  }

@Binaryify
Copy link
Owner

I see that, , I can reproduce that , and it's https://github.com/SumiMakito/Awesome-qr.js issue
could you create an issue in Awesome-qr.js repo

@Binaryify
Copy link
Owner

Binaryify commented Oct 12, 2021

I found the problem
Awesome-qr.js add the components param and the components.cornerAlignment default value is 0.5
I will add components params and change the default value to fix this

Binaryify added a commit that referenced this issue Oct 12, 2021
@Binaryify
Copy link
Owner

plz check v3.2.0

@LucaDiba
Copy link
Author

I confirm that v3.2.0 works correctly. Thanks a lot!

@Binaryify
Copy link
Owner

v3.2.0 have some problem, please update v3.2.2
you can check #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants