Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error when changing the default value of the DIFFICULTY_LEVEL property. #12

Closed
Mathijs-Bakker opened this issue Mar 21, 2024 · 1 comment

Comments

@Mathijs-Bakker
Copy link

Build error when changing the DIFFICULTY_LEVEL property.

When I change the DIFFICULTY_LEVEL other than 0 the build fails.

To repreduce:

  • Clone to edit Glorious Engrammer v36
  • Change DIFFICULTY_LEVEL other than the default value of 0
  • Build firmware

Error log:

devicetree error: 
/tmp/build/build.keymap:1867 (column 49): 
parse error: expected number or parenthesized expression

Full compile log:
Loading Zephyr default modules (Zephyr base (cached)).
-- Application: /nix/store/08q7fx9jd9r1wgsxc3vjdks9f9v4lwrz-source/app
-- CMake version: 3.27.8
-- Found Python3: /nix/store/qrrwy165fvfdxcp6yn01yjbi7fsn3zmf-python3-3.11.6-env/bin/python (found suitable version "3.11.6", minimum required is "3.8") found components: Interpreter 
-- Cache files will be written to: /tmp/.cache
-- Zephyr version: 3.5.0 (/nix/store/6p8b3xwjz1w7vijrcysij2f17fn73492-zephyr/zephyr), build: 2fad527cc5abed5bb59b4d4a4b0ee511d0e514e9
-- Using keymap file: /tmp/build/build.keymap
-- Board: glove80_lh
-- Found toolchain: gnuarmemb (/nix/store/rfmw7rw1l85rvav1fymij2253w7vz070-ccache-links)
-- Found Dtc: /nix/store/vrigkjb8pzdc01ggppbfyh6mcnnv2lzw-dtc-1.7.0/bin/dtc (found suitable version "1.7.0", minimum required is "1.4.6") 
-- Found BOARD.dts: /nix/store/08q7fx9jd9r1wgsxc3vjdks9f9v4lwrz-source/app/boards/arm/glove80/glove80_lh.dts
-- Found devicetree overlay: /tmp/build/build.keymap
In file included from <command-line>:
/tmp/build/build.keymap:319: warning: "DIFFICULTY_LEVEL" redefined
  319 | #define DIFFICULTY_LEVEL 5 // expert (100ms)
      | 
/tmp/build/build.keymap:314: note: this is the location of the previous definition
  314 | #define DIFFICULTY_LEVEL 0 // custom (see defaults below)
      | 
devicetree error: /tmp/build/build.keymap:1867 (column 49): parse error: expected number or parenthesized expression

// ...
@Mathijs-Bakker Mathijs-Bakker changed the title Build error when changing the default DIFFICULTY_LEVEL property. Build error when changing the default value of the DIFFICULTY_LEVEL property. Mar 21, 2024
sunaku added a commit that referenced this issue Mar 21, 2024
parse error: expected number or parenthesized expression

Thanks to @Mathijs-Bakker for reporting this issue #12.
@sunaku
Copy link
Owner

sunaku commented Mar 21, 2024

Thank you, this is fixed now in commit bb96f54.

Please use this updated release keymap instead (I've re-released v36 in-place):

@sunaku sunaku closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants