Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes code block escaping for lines that start with a dot. #18

Closed
wants to merge 1 commit into from

Conversation

zimbatm
Copy link
Contributor

@zimbatm zimbatm commented Apr 25, 2014

Tried on and fixes the provided sample in #17. I don't really know if other kind of blocks could benefit from that escaping.

zimbatm added a commit to direnv/direnv that referenced this pull request Apr 25, 2014
ronn is unmaintained since 2 years and it's dependency, hpricot doesn't
install anymore on ruby2+ on OSX.

Both suffer from the bug described in #113 but at least md2man is going to
be fixed. See sunaku/md2man#18
@sunaku
Copy link
Owner

sunaku commented Apr 25, 2014

Thanks! This was already done for normal text back in a9fa1f2 but now, thanks to your efforts, I realize that it also needs to be done for code blocks as well. 👍

@sunaku
Copy link
Owner

sunaku commented Apr 25, 2014

Fixed in patch branch at cc9fe16. Please verify.

@zimbatm
Copy link
Contributor Author

zimbatm commented Apr 25, 2014

Yep, you patch is working fine on my sample

@zimbatm zimbatm closed this Apr 25, 2014
zimbatm added a commit to direnv/direnv that referenced this pull request Apr 25, 2014
ronn is unmaintained since 2 years and it's dependency, hpricot doesn't
install anymore on ruby2+ on OSX.

Both suffer from the bug described in #113 but at least md2man is going to
be fixed. See sunaku/md2man#18
zimbatm added a commit to direnv/direnv that referenced this pull request Apr 25, 2014
ronn is unmaintained since 2 years and it's dependency, hpricot doesn't
install anymore on ruby2+ on OSX.

Both suffer from the bug described in #113 but at least md2man is going to
be fixed. See sunaku/md2man#18
@sunaku
Copy link
Owner

sunaku commented Apr 25, 2014

Thanks for verifying. I'll release it this weekend. :shipit:

zimbatm added a commit to direnv/direnv that referenced this pull request May 8, 2014
ronn is unmaintained since 2 years and it's dependency, hpricot doesn't
install anymore on ruby2+ on OSX.

Both suffer from the bug described in #113 but at least md2man is going to
be fixed. See sunaku/md2man#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants