-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Navigation Bar and Rail #53
Comments
Almost everything is as I suggested, great job. I would suggest a few more additions, if you don't mind:
|
I also suggest adding a NavigationLabel setting to NavigationSidebar. Will it be floating or will it hide when scrolling, like all the other buttons. |
I fixed the issue with the marquee overflow component, but the other one is just really a flutter antialiasing issue |
NavigationButton accepts two style parameter (normal and the selected one). You can style the NavigationButton like this: return NavigationButton(
style: ButtonStyle.ghost().copyWith(
iconTheme: ButtonStylePropertyAll(IconThemeData(size: 24)),
),
selectedStyle: ButtonStyle.ghost().copyWith(
iconTheme: ButtonStylePropertyAll(IconThemeData(size: 24, color: Colors.blue)),
),
label: Text(label),
child: Icon(icon),
);
Set the
See my example above.
I added the option in the latest commit also updated the example code in the docs to use the bar state instead of child state. |
I would like to keep the container square with the same aspect ratio. If I set expands to true, the container becomes rectangular |
I added |
I tried the new Navigation Bar and Rail components and noticed some issues:
When adding multiple icons there is a rendering issue.
Do the elements seem too big to you? I think they look too bulky and I would stick to the Material 3 or forui sizes.
Also, there is a lack of customization for NavigationButton. You can add modes to always show the label, hide it completely (NavigationLabelType.none not work) or show it only for the selected element. I would like to achieve a similar visual with customizations.
I tried adding NavigationBar as a child and as a footer, but in neither case there is a safe area. Rail also suffers from this problem.
I would add full-area placement to NavigationAlignment so that you can make the icons spread evenly across the available area (as it is implemented in Material).
The text was updated successfully, but these errors were encountered: