Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #38: (part 2) set the defaultCommandTimeout to 20 seconds. #52

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Issue #38: (part 2) set the defaultCommandTimeout to 20 seconds. #52

merged 2 commits into from
Jul 14, 2023

Conversation

vqmarkman
Copy link
Contributor 

       (Time, in milliseconds, to wait until most DOM based commands are considered timed out.)

vqmarkman added 2 commits July 13, 2023 11:42
@vqmarkman
Issue sundeck-io#38: (part 2) set the defaultCommandTimeout to 20 sec…
eaa15e0 
…onds.

           (Time, in milliseconds, to wait until most DOM based commands are considered timed out.)
@vqmarkman
Issue sundeck-io#38: (part 3): remove all the explicit timeouts that …
016c7a6 
…are below 20 seconds.

                     Reran all the tests locally and did not see any failures so far.
@vqmarkman vqmarkman requested a review from doronrosenberg July 13, 2023 22:21
@vqmarkman vqmarkman marked this pull request as ready for review July 13, 2023 22:21
@vqmarkman
Copy link
Contributor Author

We have last 3 hardcoded waits on the "Settings" tabs. My attempt to remove them was not successful.
I keep running into exception (Issue #35)
After this improvement, every single failure in these e2e tests needs to be looked at, debugged and fixed.

@vqmarkman vqmarkman requested a review from joshelser July 13, 2023 22:23
@joshelser joshelser merged commit bae167d into sundeck-io:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshelser joshelser joshelser approved these changes

@doronrosenberg doronrosenberg Awaiting requested review from doronrosenberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vqmarkman @joshelser