Update for io_safety being stabilized. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io_safety is now [stable in Rust 1.63]! This PR updates io-lifetimes to use the standard library types and traits when available, and use its own types and traits on older Rust versions. The traits `FromFd` and `IntoFd` are now marked as deprecated. These are replaced by `From<OwnedFd>` and `From<...> for OwnedFd` in the standard library, and users should migrate accordingly. [stable in Rust 1.63]: https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html#rust-ownership-for-raw-file-descriptorshandles-io-safety
18 tasks
And, migrate the portability types and traits to use `From<OwnedFd>` and `Into<OwnedFd>`.
This allows the `from_into_fd` extension to continue working, for now.
|
This will be a semver-incompatible change. And since the main types and traits are stablized now, I think it makes sense to make this a 1.0 release. |
notgull
approved these changes
Aug 12, 2022
src/traits.rs
Outdated
| @@ -102,6 +102,10 @@ pub trait IntoHandle { | |||
| /// let owned_handle: OwnedHandle = f.into_handle(); | |||
| /// # Ok::<(), io::Error>(()) | |||
| /// ``` | |||
| #[deprecated( | |||
There was a problem hiding this comment.
Should a deprecation notice be attached to the traits as well?
There was a problem hiding this comment.
Good spot, yes, we can deprecate IntoFd and related traits.
I didn't mark FromFd and friends as deprecated yet, because they have the from_into_fd utility functions, which some users use and find handy. Fortunately, it's just a blanket impl for any type that implements From<OwnedFd>, so it's not something users need to implement themselves.
This PR isn't deprecating `FromFd` yet, because it provides the `from_into_fd` utility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io_safety is now stable in Rust 1.63! This PR updates io-lifetimes to
use the standard library types and traits when available, and use its
own types and traits on older Rust versions.
The traits
FromFdandIntoFdare now marked as deprecated. These arereplaced by
From<OwnedFd>andFrom<...> for OwnedFdin the standardlibrary, and users should migrate accordingly.