Disable async-std and other dependencies on WASI. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the async-std, tokio, socket2, and mio dependencies into a `not(target_os = "wasi")` dependency section. This fixes the problem that the default features in async-std, which we need, depend on socket2, which doesn't work on WASI yet. The tradeoff here is that WASI users won't be able to make use of io-lifetimes' impls for these third-party crate types. But we are working to add these traits upstream, which will eventually make this unnecessary.
|
I'm open to other ideas, but for now I think this makes sense to try as 1.0.0-rc1 and see how it goes. |
|
This is now released in 1.0.0-rc1. |
sunfishcode
added a commit
that referenced
this pull request
Oct 22, 2022
* Disable async-std and other dependencies on WASI. Move the async-std, tokio, socket2, and mio dependencies into a `not(target_os = "wasi")` dependency section. This fixes the problem that the default features in async-std, which we need, depend on socket2, which doesn't work on WASI yet. The tradeoff here is that WASI users won't be able to make use of io-lifetimes' impls for these third-party crate types. But we are working to add these traits upstream, which will eventually make this unnecessary. * Add testing on Rust 1.48. * Add an MSRV note to README.md. * Disable deprecation warnings in impls_std.rs.
sunfishcode
added a commit
that referenced
this pull request
Oct 22, 2022
* Disable async-std and other dependencies on WASI. Move the async-std, tokio, socket2, and mio dependencies into a `not(target_os = "wasi")` dependency section. This fixes the problem that the default features in async-std, which we need, depend on socket2, which doesn't work on WASI yet. The tradeoff here is that WASI users won't be able to make use of io-lifetimes' impls for these third-party crate types. But we are working to add these traits upstream, which will eventually make this unnecessary. * Add testing on Rust 1.48. * Add an MSRV note to README.md. * Disable deprecation warnings in impls_std.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the async-std, tokio, socket2, and mio dependencies into a
not(target_os = "wasi")dependency section. This fixes the problemthat the default features in async-std, which we need, depend on
socket2, which doesn't work on WASI yet.
The tradeoff here is that WASI users won't be able to make use of
io-lifetimes' impls for these third-party crate types. But we are
working to add these traits upstream, which will eventually make
this unnecessary.