[FIX] Modify how employee attedance is computed #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some cases, we could have capacity consumed by a task which was not matching a work capacity line in the period because of a faulty optimisation we were making which skipped the creation of lines with a capacity of 0 -> then we had no line on which to compute the negative consolidated capacity. We remove the optimisation to fix this case and show the problematic periods in the consolidated capacity graphs
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/
During some operations, forecast lines are deleted and recreated. This can lead to some hr.employee.forecast.role lines being deleted which leaves the forecast lines on the same period without a related document to store the consolidated capacity. Normally that line is recreated shortly afterwards but the creation does not recompute the link between the parent-less lines and the new one. This patches forces the recomputation when new lines are created.
…tion states" This reverts commit 82f5f36.
The idea is to have two consolidated forecast fields, instead of setting.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/
Add computed fields to written fields to trigger forecast lines update
Add hook for several UoM hours/days conversion
…oyee is not active
Fix an issue in project_forecast_line where lines would be removed by the cron. When an employee has a forecast role with an end date set, depending on the order of the processing of records in the cron, a bug could remove forecast lines of other employees when attempting to remove the forecast lines related to thatrole which had been generated after the end date in previous runs (before the end date was set). Fix this by using the correct domain.
Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
when running in multi company, sometimes the user making a change is not connected using the company of the record. In this case the default value for company_id on forecast.line will lead to a wrong forecast. we fix this by using the best company when updating the forecast (the employee's company for task assigned to employees or leaves, the sale line's company for sales forecast
the condition was wrong, preventing the fast update from being used when only the remaining time is updated
Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
when using the quick update, we would get an inversion of the sign of the forecast because the ratio was negative
…le in hr.employee.public
Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/
Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Currently translated at 100.0% (95 of 95 strings) Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
ntsirintanis
approved these changes
Oct 23, 2024
|
@ntsirintanis Should I merge this in? It will probably make your PR red |
ntsirintanis
force-pushed
the
16.0-mig-project_forecast_line
branch
from
a5080b7 to
60e358f
Compare
|
@QuiJoQuim thanks for this MR! Please rebase, let's see if we can make this green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The employee's attendance calculated the days differently by the total hours than by the distribution.
This resulted in attendances of 40.39 hours in 3 months and things like that.
This PR corrects this behavior.