[14.0][FIX] Fails on hr.employee.public record #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsirintanis
approved these changes
Dec 14, 2022
ntsirintanis
force-pushed
the
14.0-backport-project_forecast_line
branch
from
7ee8af8 to
e82eb81
Compare
ntsirintanis
force-pushed
the
14.0-backport-project_forecast_line-hr_employee_public_fix
branch
2 times, most recently
from
9d29c6e to
0f1e7dc
Compare
in some cases, we could have capacity consumed by a task which was not matching a work capacity line in the period because of a faulty optimisation we were making which skipped the creation of lines with a capacity of 0 -> then we had no line on which to compute the negative consolidated capacity. We remove the optimisation to fix this case and show the problematic periods in the consolidated capacity graphs
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/
ntsirintanis
force-pushed
the
14.0-backport-project_forecast_line
branch
from
e82eb81 to
85e829e
Compare
ntsirintanis
force-pushed
the
14.0-backport-project_forecast_line-hr_employee_public_fix
branch
from
0f1e7dc to
46d4234
Compare
During some operations, forecast lines are deleted and recreated. This can lead to some hr.employee.forecast.role lines being deleted which leaves the forecast lines on the same period without a related document to store the consolidated capacity. Normally that line is recreated shortly afterwards but the creation does not recompute the link between the parent-less lines and the new one. This patches forces the recomputation when new lines are created.
In some cases you can have a project without a status set -> in this case we don't want to generate forecast lines (and we don't want a crash either)
…tion states" This reverts commit 82f5f36.
The idea is to have two consolidated forecast fields, instead of setting.
thomaspaulb
force-pushed
the
14.0-backport-project_forecast_line
branch
from
85e829e to
d696a91
Compare
in some cases, we could have capacity consumed by a task which was not matching a work capacity line in the period because of a faulty optimisation we were making which skipped the creation of lines with a capacity of 0 -> then we had no line on which to compute the negative consolidated capacity. We remove the optimisation to fix this case and show the problematic periods in the consolidated capacity graphs
in some cases, we could have capacity consumed by a task which was not matching a work capacity line in the period because of a faulty optimisation we were making which skipped the creation of lines with a capacity of 0 -> then we had no line on which to compute the negative consolidated capacity. We remove the optimisation to fix this case and show the problematic periods in the consolidated capacity graphs
… access because then rec is a hr.employee.public record
…eadonly access because then rec is a hr.employee.public record
… with readonly access because then rec is a hr.employee.public record
ntsirintanis
force-pushed
the
14.0-backport-project_forecast_line-hr_employee_public_fix
branch
from
46d4234 to
1cfd05e
Compare
ntsirintanis
force-pushed
the
14.0-backport-project_forecast_line
branch
2 times, most recently
from
00d09bb to
9d0af2a
Compare
ntsirintanis
force-pushed
the
14.0-backport-project_forecast_line
branch
from
1483eb0 to
248b19f
Compare
ntsirintanis
force-pushed
the
14.0-backport-project_forecast_line
branch
3 times, most recently
from
2ae9ed9 to
7c389c0
Compare
gjotten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails when the field is being read by a user with readonly access because then rec is a hr.employee.public record:
https://github.com/OCA/project/blob/15.0/project_forecast_line/models/hr_employee.py#L27