-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] get pins script #26
base: master
Are you sure you want to change the base?
Conversation
6014517
to
7176c2c
Compare
98c11e1
to
7f1383d
Compare
@thomaspaulb @Hussam-Suleiman completed, ready for review. ./get_pins will output the text of a pinned repos.yaml of the current deployment. The script pins everything, here is an example of running it on my local FF test there is also an option --only-base=True where it pins only the first merge (base branch). I also built with the output of the script and all worked well. PROPOSED EXTENSION:
As it is now , output can be copy/pasted in repos.yaml and it works. |
@thomaspaulb i put this in WIP again. |
@thomaspaulb Refactor done and added support for pinning target: example: gives:
While
|
@gfcapalbo Please use:
And a Usage function as described here: https://www.artima.com/weblogs/viewpost.jsp?thread=4829 (But keep the more modern argparse etc. the blog was written a long time ago). |
@NL66278 @thomaspaulb added support for imposing the correct merge, and followed through @NL66278 's comments/ Diff, you can see that where the necessary depth merge exceeds the waft_depth_merge variable it is replaced by the correct value + 25. ( I added 25 because if we used the precise value, by the time we deploy the new yaml , new commits may have already been added, making that value insufficient) So now the script offers complete pinning and the certainty of "sufficient" depth values for every repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
could not reply directly in threads.... some bug. ......now it notifies: Also replacing all ENV variables as suggested, that means all WAFT_DEPTH_MERGE and all WAFT_DEPTH_DEFAULT are replaced too, is that okay? |
@thomaspaulb ALl requests done. I will make Danny's translation script execution in a separate branch. |
@thomaspaulb it seems that danny has alreadyu done the script-calling-python thing in MR: merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments still
f1f1e4a
to
47aeef2
Compare
@thomaspaulb done all suggestions:
|
5d037bf
to
eadeb3d
Compare
@thomaspaulb tested for more than an Hour on FF prd and FF tst, the int > string comparison error never happens and never can happen after my latest update. please verify latest version installed. |
eadeb3d
to
c10144d
Compare
c10144d
to
106322a
Compare
Hey giovanni, maybe it would be nice if the script has the execution permission. |
Script to extract all pins from a built waft instance.
use:
to replicate faithfully the pins of a test instance on a prd instance.