[ADD] #9500 Added the migration script to waft. #29

ddejong-therp · 2023-05-11T09:58:32Z

I've added the migration script to waftlib. Not 100% sure if the placement of files/directories is in line with the conventions. But that can always be changed of course.

Another thing I still like to change, is the fact that currently the builds of the migration are build when you use the -r switch in the migration script. However, maybe it is more nice if that is included into the ./build script. Maybe the build script can detect whether a migration is enabled in .env-*, and if so, set up the intermediate migration builds as well.
Perhaps I can still do this once the clouds clear up and I have some time. :)

thomaspaulb · 2023-05-15T09:43:53Z

templates/16.0/.python-version

@@ -1 +1 @@
-3.10.6
+3.7.12


@ddejong-therp Why this change? Several of our instances are currently happily running on Python 3.10.6 and would be reverted to 3.7.12 on the next run of ./bootstrap, so we'd have to plan that in a weekend and run into all sorts of problems - I'd rather not do that unless there's a good reason

Ah that is a good question. I actually don't really know. I think it was because I assumed that it was 3.6 before, so I assumed I changed it to something weird. Must have been a brainfart...

thomaspaulb · 2023-05-15T09:51:29Z

@ddejong-therp I also see one conflict, can you rebase?

thomaspaulb · 2023-05-15T09:53:28Z

Another thing I still like to change, is the fact that currently the builds of the migration are build when you use the -r switch in the migration script. However, maybe it is more nice if that is included into the ./build script.

Personally I would keep this separate, so that we decrease the risk of improvements in our migration script causing regressions with the ./build command of other Waft instances.

ddejong-therp · 2023-05-17T08:28:41Z

Another thing I still like to change, is the fact that currently the builds of the migration are build when you use the -r switch in the migration script. However, maybe it is more nice if that is included into the ./build script.

Personally I would keep this separate, so that we decrease the risk of improvements in our migration script causing regressions with the ./build command of other Waft instances.

yeah that's fair.

thomaspaulb · 2024-02-08T08:39:55Z

bin/migrate.py

@@ -1011,7 +1011,7 @@ def run_upgrade(version):
        else MIGRATION_PATH + '/build-' + version

    logfile = os.path.join(WAFT_DIR, 'logfile', instance + '.log')
-    args = '-u all --stop-after-init --logfile "%s"' % logfile
+    args = '-u base --stop-after-init --logfile "%s"' % logfile


@ddejong-therp What's the difference?

The difference shows up when you are trying to get modules removed using the 'to remove' state.

Right now, the uninstall script only puts the modules to be uninstalled in the 'to remove' state, because if you use the button_immediate_uninstall function, that sometimes only puts the module in the 'to remove' state anyway, which should get uninstalled later. But because I was running it from a shell, there was not future opportunity to get those modules uninstalled.

Another way to trigger the uninstallation of 'to remove' modules, is to run odoo with the upgrade switch (-u). However, if you upgrade the module with the 'to remove' state itself, it will also update the state field back to 'installed', before triggering the code that continues to remove the 'to remove' modules.
When you use -u all, you reset all the modules state back to 'installed', and when you use -u base, you don't, but you still trigger the code that does the uninstallation.

Wow, ok. I didnt know that.

thomaspaulb · 2024-09-24T10:43:06Z

bin/migrate.py

-            cmd_system(os.path.join(build_dir, "bootstrap"))
-        with open(os.path.join(build_dir, ".env-secret"), "r") as file:
+        env_secret_template = os.path.join(build_dir, "waftlib/templates/.env-secret")
+        with open(env_secret_template, "r") as file:


@ddejong-therp Do you still run bootstrap somewhere though?

…ersion of 15.0

…nymore

…se.url is empty

…tables as well

…igger foreign key constraints even if not necessary.

…o fail

…grade to 14.0

…gory's

…re, to save space

thomaspaulb requested changes May 15, 2023

View reviewed changes

ddejong-therp force-pushed the migration-script branch from ba16fd3 to 88e2403 Compare September 7, 2023 14:17

ddejong-therp force-pushed the migration-script branch from 061ecb3 to a7a38d8 Compare October 9, 2023 11:56

ddejong-therp force-pushed the migration-script branch 3 times, most recently from 781b606 to 5cedf79 Compare October 20, 2023 17:17

ddejong-therp force-pushed the migration-script branch from 71ef026 to 54afbb1 Compare December 6, 2023 11:50

thomaspaulb reviewed Feb 8, 2024

View reviewed changes

ddejong-therp force-pushed the migration-script branch from 02b1f5a to 3b78db9 Compare March 22, 2024 14:19

ddejong-therp force-pushed the migration-script branch 7 times, most recently from 99a6ff3 to e992c3e Compare May 29, 2024 10:16

ddejong-therp force-pushed the migration-script branch from 662d65f to 4a1dabd Compare June 12, 2024 10:29

ddejong-therp force-pushed the migration-script branch 3 times, most recently from 19da9ee to 8724e5d Compare September 16, 2024 10:37

ddejong-therp force-pushed the migration-script branch 5 times, most recently from 6cb23d1 to 3e84fda Compare September 23, 2024 08:14

thomaspaulb reviewed Sep 24, 2024

View reviewed changes

ddejong-therp force-pushed the migration-script branch from 6619e18 to 29653ec Compare September 24, 2024 13:04

ddejong-therp and others added 21 commits November 18, 2024 13:07

[FIX] Don't update columns which are nullable

90800c2

[ADD] Add an option to disable openupgrade upgrades

758cc6a

[FIX] Don't update table names that are ending with _rel

acf4cb6

[FIX] Fix issue when enterprise-jump-to was empty

32480b7

[IMP] The enterprise migration script now requires a minimum target v…

807a7a3

…ersion of 15.0

[IMP] Add some additional logging

fa06e1b

[ADD] Remove duplicates in mail_notification for 16.0

8cd934f

[IMP] Blacked the migration scripts

63e5611

[ADD] Ignore progress.json

972baf8

[REM] Cleaning views after each enterprise upgrade step is not good a…

e1269bd

…nymore

[ADD] Add a workaround for an error that tends to shop up when web.ba…

dbd535e

…se.url is empty

[ADD] Add a pre-migration script to clean the actions of the database.

4f6caf1

Set purger logs to debug level

21b1501

[IMP] Use the new purge code to clean the ir.model & ir.model.fields …

6fd0ab5

…tables as well

[FIX] Fix action cleanup script

069f54a

[REM] Don't always run cleanup at the end. It might break stuff.

1b1f857

[IMP] Search for progress.json in the waft dir

eb26b4f

[ADD] Add the manufacture-reporting repo

8db33cd

[FIX] Delete queue jobs, don't truncate them. Truncate will always tr…

2da1997

…igger foreign key constraints even if not necessary.

Add stop odoo service to migrate script

0b3781c

[IMP] Remove addresses of fetchmail servers

b956ec2

ddejong-therp force-pushed the migration-script branch from dea8782 to b956ec2 Compare November 18, 2024 12:07

ddejong-therp added 4 commits November 18, 2024 14:18

[FIX] Don't break when a cleanup query has been executed that is ok t…

17d3f57

…o fail

[IMP] Workaround for pgport issue in waft

6b4b2ef

[FIX] Uninstall modules with button_immediate_uninstall again.

578f48d

[ADD] Give an error when the bank statement lines are not valid to up…

9bc9033

…grade to 14.0

ddejong-therp force-pushed the migration-script branch from c03c683 to 9bc9033 Compare December 16, 2024 14:07

ddejong-therp added 3 commits December 16, 2024 15:26

[ADD] Fix issues with missing category_id's for ir.module.module.cate…

08dbde1

…gory's

[IMP] Don't keep an extra copy for each enterprise database's filesto…

5499017

…re, to save space

[ADD] Add a no-backups configuration option

117d9da

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] #9500 Added the migration script to waft. #29

[ADD] #9500 Added the migration script to waft. #29

ddejong-therp commented May 11, 2023

thomaspaulb May 15, 2023

ddejong-therp May 17, 2023

thomaspaulb commented May 15, 2023

thomaspaulb commented May 15, 2023

ddejong-therp commented May 17, 2023

thomaspaulb Feb 8, 2024

ddejong-therp Feb 9, 2024 •

edited

Loading

thomaspaulb Feb 9, 2024

thomaspaulb Sep 24, 2024

[ADD] #9500 Added the migration script to waft. #29

Are you sure you want to change the base?

[ADD] #9500 Added the migration script to waft. #29

Conversation

ddejong-therp commented May 11, 2023

thomaspaulb May 15, 2023

Choose a reason for hiding this comment

ddejong-therp May 17, 2023

Choose a reason for hiding this comment

thomaspaulb commented May 15, 2023

thomaspaulb commented May 15, 2023

ddejong-therp commented May 17, 2023

thomaspaulb Feb 8, 2024

Choose a reason for hiding this comment

ddejong-therp Feb 9, 2024 • edited Loading

Choose a reason for hiding this comment

thomaspaulb Feb 9, 2024

Choose a reason for hiding this comment

thomaspaulb Sep 24, 2024

Choose a reason for hiding this comment

ddejong-therp Feb 9, 2024 •

edited

Loading