Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

Make keyserver configurable and fix faraday (berkshelf version bump) #11

Merged
merged 2 commits into from Nov 15, 2015
Merged

Conversation

dennisvink
Copy link

Allow for the default keyserver.ubuntu.com keyserver override.

@dennisvink
Copy link
Author

The new faraday gem is incompatible with Berkshelf 3.x. I've bumped the version to ~> 4.0.0 to resolve this.

@dennisvink dennisvink changed the title Make keyserver configurable Make keyserver configurable and fix faraday (berkshelf version bump) Oct 29, 2015
@sunggun-yu
Copy link
Owner

Thank you for the PR!

@sunggun-yu
Copy link
Owner

Hi, @megamoth !

Thank you for your PR. and, I have question for this PR.
I'm just curios, Is there any specific reason that make it configurable?

@dennisvink
Copy link
Author

Greetings @sunggun-yu !

I've made it configurable to be able to continue with deploys when the default keyserver is down. It's not an uncommon occurance :-P

@sunggun-yu
Copy link
Owner

Thank you for your explanations.
I'll merge it. however, I'll change some portion of it. I've decided to provide it as ['mongodb3']['package']['repo'] attribute in order to make it configurable. it will be worth to resolve #10 like issues.

sunggun-yu added a commit that referenced this pull request Nov 15, 2015
Make keyserver configurable and fix faraday (berkshelf version bump)
@sunggun-yu sunggun-yu merged commit 0505fc9 into sunggun-yu:develop Nov 15, 2015
@sunggun-yu
Copy link
Owner

opps, I confused, I'm not saying about keyserver. I'm saying about uri. sorry for make you confused.

@sunggun-yu sunggun-yu mentioned this pull request Nov 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants