-
Notifications
You must be signed in to change notification settings - Fork 58
Adding support for ubuntu 15.04 and 16.04 #39
Conversation
|
||
supports 'ubuntu', '= 12.04' | ||
supports 'ubuntu', '= 16.04' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be supports 'ubuntu', '>= 12.04'
or unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, I will fix this
Works for me on a generic |
@@ -97,7 +97,11 @@ | |||
when 'debian' | |||
apt_repository "mongodb-org-#{pkg_major_version}" do | |||
uri node['mongodb3']['package']['repo']['url'] | |||
distribution "#{node['lsb']['codename']}/mongodb-org/#{node['mongodb3']['package']['repo']['apt']['name']}" | |||
if node['platform'] == 'ubuntu' and node['platform_version'].to_f >= 15.04 | |||
distribution "trusty/mongodb-org/#{node['mongodb3']['package']['repo']['apt']['name']}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://repo.mongodb.org/apt/ubuntu/dists/xenial/mongodb-org/ exists for 16.04 so this should be = 15.04
instead.
Looks like mongodb does only support LTS-Versions with their repository. Isn't support for 15.04
mostly a hack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, seems so they support only LTS versions:
Platform Support
MongoDB only provides packages for 64-bit long-term support Ubuntu releases. Currently, this means 12.04 LTS (Precise Pangolin) and 14.04 LTS (Trusty Tahr). While the packages may work with other Ubuntu releases, this is not a supported configuration.
I agree that support of 15.04 might be considered as a hack, but mongodb release for 14.04 works on 15.04 as well. I will fix this condition and force trusty/mongodb-org release only for 15.04
Thank you @goatherd for your comments, I've already applied fixes. |
Cool, that was fast. Really helped me a lot! |
? |
Why this PR is open since 2 month? Come on guys. Can you decide a new maintainer when you have no time for this project please? |
@aight8 sorry for the late. I was away from chef for several month. sorry again. I need some collaborators. lol |
@sunggun-yu |
- Update default mongodb version as 3.2.8 - Adding Kitchen testing platforms : ubuntu 15.04 and 16.04 ! Some test cases are still failing !
There were few breaking changes in Ubuntu 15.04 and 16.04 which made this cookbook incompatible like:
I got some problems with running Ubuntu 16.04 on Vagrant machine (private network required by Vagrant doesn't work properly on official vagrant box for Ubuntu 16.04 and network interfaces names were also changed and Vagrant expects eth0/eth1) so just to simplify this process you can use below configuration:
Vagrantfile
./bin/ubuntu_vm_fix.sh
Just let me know if you will have any problems or questions