feature(auth): add SRP authentication #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungly
force-pushed
the
feature/add-srp-login
branch
from
ec3f21b to
a4aced1
Compare
rocellaj
reviewed
Jan 6, 2021
| @@ -28,9 +29,14 @@ const cli = () => { | |||
|
|
|||
| break; | |||
| case 'login': | |||
| logger.info('@NOTE: Only user password auth is supported ATM.'); | |||
There was a problem hiding this comment.
thoughts of doing another prompt here - or providing option of which type of login ?
There was a problem hiding this comment.
hmmm I'm okay just leaving as is since we're only going to have two types.
There was a problem hiding this comment.
we could tackle this on a different ticket?
sungly
added a commit
that referenced
this pull request
Jan 8, 2021
* update prompt and Winston versions * update logger import * update read me * moved addSecretHashToParams to hash util
sungly
pushed a commit
that referenced
this pull request
Jan 8, 2021
# [1.4.0](v1.3.0...v1.4.0) (2021-01-08) ### Features * **auth:** add SRP authentication ([#25](#25)) ([9f5aedc](9f5aedc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
How to test locally
npm run cognito srp-loginand login with your username and password