Fix cargo doc warning by explicitly matching /README.md in Cargo.toml #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for fixing this! Could you explain what the change was so I know for the future? |
|
Basically, there are two README.md files in turtle, the one at /README.md and the one at /docs/README.md. Previously, the include match in Cargo.toml would match only the root one, but it's being changed so the pattern matches ANY file unless the pattern explicitly matches the root. So by changing Cargo.toml to match /README.md explicitly, the warning is no longer produced because only one file matches. (At least, that is my understanding.) |
|
Thank you this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #91