Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop rustc_serialize support #136

Closed
sunng87 opened this issue Jan 28, 2017 · 3 comments
Closed

Drop rustc_serialize support #136

sunng87 opened this issue Jan 28, 2017 · 3 comments
Milestone

Comments

@sunng87
Copy link
Owner

sunng87 commented Jan 28, 2017

Rustc_serialize support will sunset. There will be a 0.x version that use serde as default type system and allow rustc_serialize via feature flag. And in 1.0 release there will be no rustc_serialize for this library.

@sunng87 sunng87 added this to the 1.0 milestone Jan 28, 2017
@sunng87
Copy link
Owner Author

sunng87 commented Mar 2, 2017

Cargo is using handlebars with rustc_serialize so we probably won't drop it in near future.

@sunng87 sunng87 closed this as completed Mar 2, 2017
@dtolnay
Copy link

dtolnay commented Mar 2, 2017

@sunng87 I would encourage you to reconsider this. Cargo is very interested in moving to Serde-based handlebars. Quoting from rust-lang/cargo#3682:

This doesn't completely excise the dependency just yet as docopt still requires it along with handlebars. I'm sure though that in time those crates will migrate to serde!

Also according to the Rust release milestone predictions, rustc-serialize is scheduled to be deprecated in next month's beta release.

@sunng87
Copy link
Owner Author

sunng87 commented Mar 3, 2017

@dtolnay Thank you for pointing out this. Then I will definitely sunset rustc_serialize support in next release.

@sunng87 sunng87 reopened this Mar 3, 2017
sunng87 added a commit that referenced this issue Mar 5, 2017
Signed-off-by: Ning Sun <sunng@about.me>
sunng87 added a commit that referenced this issue Apr 22, 2017
Signed-off-by: Ning Sun <sunng@about.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants