Skip to content
This repository has been archived by the owner on Dec 24, 2017. It is now read-only.

pagination doesn't work on android #1

Open
httnn opened this issue Dec 15, 2015 · 9 comments
Open

pagination doesn't work on android #1

httnn opened this issue Dec 15, 2015 · 9 comments

Comments

@httnn
Copy link

httnn commented Dec 15, 2015

first of all, thank you for this fork!

I just noticed that on Android it scrolls like a normal ScrollView without snapping to the views, have you noticed this?

here's how I use it:

<Swiper loop={false}>
...  
</Swiper>
@sunnylqm
Copy link
Owner

It does not support Android yet. It needs to use ViewPager instead of ScrollView on Android, which is still work in progress.

@httnn
Copy link
Author

httnn commented Dec 16, 2015

oh so the original component didn't support android either? why can't
android use ScrollView too?
On Dec 16, 2015 02:38, "sunnylqm" notifications@github.com wrote:

It does not support Android yet. It needs to use ViewPager instead of
ScrollView on Android, which is still work in progress.


Reply to this email directly or view it on GitHub
#1 (comment)
.

@sunnylqm
Copy link
Owner

Because pagingEnabled prop of ScrollView is now ios only.

@httnn
Copy link
Author

httnn commented Dec 16, 2015

ah I see. I might need to do a PR with a fix soon.

@httnn httnn closed this as completed Dec 16, 2015
@httnn httnn reopened this Dec 16, 2015
@sunnylqm
Copy link
Owner

PR would be great!

@httnn
Copy link
Author

httnn commented Dec 17, 2015

actually, as I don't need any of the extra functionality (just need the paging), I think I'm going to go with a custom component for my project. would be too much work to implement all the options for android separately, but maybe I'll try that later. or would you accept a PR where on Android there would just be the paging, all other features disabled? maybe in a new branch dedicated for android support?

@sunnylqm
Copy link
Owner

Any progress will be accepted if it does not break current functions.

@shukerullah
Copy link

+1
Pagination does not work properly on Android if loop is disabled / false.

@shukerullah
Copy link

Why this issue is closed? Pagination is still not working properly on Android.

@sunnylqm sunnylqm reopened this Aug 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants