Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using 2.3.1 in UICollectionViews or similar #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

Fix crash when using 2.3.1 in UICollectionViews or similar #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions XXNibBridge/XXNibBridge.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ + (UIView *)instantiateRealViewFromPlaceholder:(UIView *)placeholderView {
// Copy autolayout constrains.
if (placeholderView.constraints.count > 0) {

// Capture the placeholderView until the end of the current run loop cycle.
// This is needed when a view is initialized within a layoutSubviews call
// (example: UICollectionView cells).
// In this case iOS still evaluates the placeholder constraint, which without
// the capture would have a dangling pointer on the `firstItem` property.
dispatch_async(dispatch_get_main_queue(), ^{
(void)placeholderView;
});

// We only need to copy "self" constraints (like width/height constraints)
// from placeholder to real view
for (NSLayoutConstraint *constraint in placeholderView.constraints) {
Expand Down