Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with dropping elements outside regions #36

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

sunpietro
Copy link
Owner

Problematic use case:

  1. Drag an element,
  2. Move onto a dropzone,
  3. The placeholder appears,
  4. Move outside the dropzone,
  5. Drop element,
  6. The element is dropped on a dropzone.

Expected result:

The element should not be dropped. No change should occur.

Improved:

  • started listening to mouseup/touchend events when a user starts dragging an element,
  • clearing dragster regions when the onBeforeDragEnd callback returns false.

@sunpietro sunpietro merged commit f51adca into master Mar 30, 2017
@sunpietro sunpietro deleted the fix-drop-event-handling branch March 30, 2017 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant