Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add classes to post elements #121

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

jon-walton
Copy link
Contributor

Description

It's difficult to get consistent styling between .. postlist:: and the archive pages. This PR adds classes to each part of a post to help with styling.

There was also a difference between how .. postlist:: rendered the expand vs the archive pages. The archive now follows .. postlist::

@nabobalis
Copy link
Contributor

nabobalis commented Jan 3, 2022

Looks like a test output (test_postlist_date_format_conf ) needs to be updated now.

@jon-walton
Copy link
Contributor Author

gah, sorry. are there any docs on running the tests locally?

@nabobalis
Copy link
Contributor

Good question, I don't think there are. It was a recent addition and we forgot to add any.

Running pytest ./ in a dev environment (assuming you have everything installed) should work.

@jon-walton
Copy link
Contributor Author

thanks @nabobalis , tests are passing locally now

tests/test_postlist.py Outdated Show resolved Hide resolved
tests/test_postlist.py Outdated Show resolved Hide resolved
@nabobalis nabobalis merged commit 02fe7c9 into sunpy:main Jan 3, 2022
@nabobalis
Copy link
Contributor

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants