Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make newlines of all files consistent #127

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Make newlines of all files consistent #127

merged 1 commit into from
Feb 25, 2022

Conversation

pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Feb 25, 2022 •
edited
Loading 

❯ git show HEAD:ablog/templates/catalog.html | file -
/dev/stdin: HTML document text, ASCII text
❯ git show HEAD^1:ablog/templates/catalog.html | file -
/dev/stdin: HTML document text, ASCII text, with CRLF line terminators

Currently, a few files in the git repository have CRLF line terminators while the vast majority have LF line terminators. This PR changes all the files (that aren't windows-specific files, as listed here) from CRLF to LF line terminators.

Spotted this while working on #125 (my git configuration caught this issue, see link above).

@pradyunsg
Copy link
Contributor Author

The CI failure is the same as what can be seen on main.

@nabobalis nabobalis merged commit 0d06404 into sunpy:main Feb 25, 2022
@pradyunsg pradyunsg deleted the gitattributes-cleanup branch February 26, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyunsg @nabobalis