Fix warnings and update CI #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
force-pushed
the
ci
branch
4 times, most recently
from
6c9ab01 to
73412de
Compare
nabobalis
commented
Jul 9, 2022
Comment on lines
-682
to
-684
| base_url = url | ||
| if len(blog.blog_languages) > 1: | ||
| base_url = os_path_join(url, app.config.language) |
There was a problem hiding this comment.
I think this had a purpose but right now I can't work out when the language would be in the URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to enable treat warnings as errors and turns out, lots of warnings.
Fixes #137 in theory
Fixes #136 in theory