Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for code that raises pandas warning #73

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Oct 3, 2022

Should fix #72. It looks like the warning is a mistake on pandas part (pandas-dev/pandas#48701) which will be fixed in their next bugfix release, 1.5.1.

@nabobalis nabobalis merged commit 7960d8b into sunpy:main Oct 3, 2022
@ConorMacBride
Copy link
Member

I just ran the tox env py310-sunpy on the pandas git repo and the warning is still shown. I think the issue referenced above is different to the warning? The drms pytest config should be updated to raise all warnings as errors. That way the new test can fail if a warning is presented.

@dstansby dstansby deleted the pandas-warning branch October 4, 2022 15:13
@dstansby dstansby mentioned this pull request Oct 4, 2022
@dstansby
Copy link
Member Author

dstansby commented Oct 4, 2022

Woops, my bad. I've had more of a look into this and can't work out how to map the warning

FutureWarning: In a future version, `df.iloc[:, i] = newvals` will attempt to set the values inplace instead of always setting a new array. To retain the old behavior, use either `df[df.columns[i]] = newvals` or, if columns are non-unique, `df.isetitem(i, newvals)`
/home/runner/work/sunpy/sunpy/docs/guide/acquiring_data/jsoc.rst:60: UnexpectedException

to a change in the code, given we're not taking an empty slice as the first argument to iloc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas warnings
3 participants