Initial implementation for validating two WCS #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
reviewed
Jun 22, 2021
|
Hello @adwaitbhope! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! Comment last updated at 2021-07-07 16:44:45 UTC |
|
I've added test cases for this function, but for the positive test case, we have the same object as source and target. Should we introduce another WCS in the fixtures? |
I don't think it's necessary at this stage. The test as is adequately tests the current implementation. If/when this function moves to a more complicated implementation, adapting the test should be part of the work. Adding a new fixture would be part of that. |
Cadair
reviewed
Jul 5, 2021
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Cadair
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #428.
An initial implementation of the validate function for checking if two WCS objects are compatible with each other to reproject an
NDCubeon top of another.