Add tests with a jsoc cutout file and update MGN to convert int to float #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
force-pushed
the
cutout
branch
3 times, most recently
from
95113e3 to
03da3d7
Compare
wtbarnes
reviewed
Jul 8, 2024
nabobalis
force-pushed
the
cutout
branch
4 times, most recently
from
41daef1 to
6667eff
Compare
nabobalis
force-pushed
the
cutout
branch
7 times, most recently
from
80f9d85 to
bd778e0
Compare
nabobalis
commented
Jul 20, 2024
nabobalis
commented
Jul 20, 2024
nabobalis
commented
Jul 20, 2024
nabobalis
force-pushed
the
cutout
branch
9 times, most recently
from
42a55b1 to
e36cba5
Compare
nabobalis
force-pushed
the
cutout
branch
5 times, most recently
from
e511b03 to
9e2dfd8
Compare
alasdairwilson
approved these changes
Aug 1, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nabobalis
force-pushed
the
cutout
branch
2 times, most recently
from
de4eecf to
4cb4a41
Compare
nabobalis
force-pushed
the
cutout
branch
3 times, most recently
from
38cf515 to
80c7c3e
Compare
nabobalis
commented
Nov 13, 2024
There was a problem hiding this comment.
This is jut a end of file character change.
nabobalis
commented
Nov 13, 2024
There was a problem hiding this comment.
This is jut a end of file character change.
nabobalis
force-pushed
the
cutout
branch
3 times, most recently
from
ecc31e0 to
16d6fd9
Compare
nabobalis
commented
Nov 13, 2024
| for s, weight in zip(sigma, weights, strict=True): | ||
| # 2 & 3 Create kernel and convolve with image | ||
| # Refer to equation (1) in the paper | ||
| ndimage.gaussian_filter(data, sigma=s, truncate=truncate, mode="nearest", output=conv) | ||
|
|
||
| # 4. Calculate difference between image and the local mean image, | ||
| # square the difference, and convolve with kernel. Square-root the | ||
| # resulting image to give `local standard deviation` image sigmaw | ||
| # Refer to equation (2) in the paper | ||
| conv = data - conv | ||
| ndimage.gaussian_filter(conv**2, sigma=s, truncate=truncate, mode="nearest", output=sigmaw) | ||
| np.sqrt(sigmaw, out=sigmaw) |
There was a problem hiding this comment.
> np.sqrt(sigmaw, out=sigmaw)
E numpy._core._exceptions._UFuncOutputCastingError: Cannot cast ufunc 'sqrt' output from dtype('float32') to dtype('int16') with casting rule 'same_kind'So this is the original issue that we need to fix.
To fix this, I just always cast the input data to float32.
nabobalis
changed the title
nabobalis
changed the title
wtbarnes
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Issue was reported with JSOC cutouts and the datatype breaking these routines.