Add gamma_min/max as kwargs #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @wtbarnes! Thanks for updating this PR.
Comment last updated at 2021-04-21 18:36:45 UTC |
nabobalis
approved these changes
Apr 22, 2021
|
Thanks for the PR!. I don't think we need to worry about that test. |
|
Oops I just realized I don't have precommit installed on my local version of sunkit-image... |
|
It's fine, I dealt with all of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the IDL implementation (see https://solarphysics.aber.ac.uk/mgn.pro), the minimum and maximum values for the gamma-transform, called
a0anda1, are input arguments. However, in this translation, they are fixed as the min and max values of the image. This PR makes them arguments that default to the min and max of the image. This should probably include a test for non-None values of these kwargs...