Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearranged examples with the current functionality #30

Merged
merged 15 commits into from
Jul 4, 2021
Merged

Rearranged examples with the current functionality #30

merged 15 commits into from
Jul 4, 2021

Conversation

jeffreypaul15
Copy link
Collaborator

@jeffreypaul15 jeffreypaul15 commented Jun 29, 2021 •
edited
Loading

@nabobalis nabobalis marked this pull request as draft July 1, 2021 09:10
@nabobalis nabobalis marked this pull request as ready for review July 1, 2021 18:57
nabobalis
nabobalis reviewed Jul 1, 2021
View reviewed changes
changelog/30.trivial.rst Outdated Show resolved Hide resolved
@jeffreypaul15 jeffreypaul15 changed the title Example for plotting a tiny sphere on the brightest pixel Rearranged examples with the current functionality Jul 1, 2021
jeffreypaul15 and others added 3 commits July 2, 2021 03:37
nabobalis
nabobalis reviewed Jul 2, 2021
View reviewed changes
examples/skip_plot_functionality.py Outdated
Adding extra features
=====================

sunkit-pyvista also extends ``draw_quadrangle``, and ``plot_coord`` from `sunpy`, producing them in 3D.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@nabobalis nabobalis merged commit d50dc81 into sunpy:main Jul 4, 2021
@jeffreypaul15 jeffreypaul15 mentioned this pull request Jul 16, 2021
Closed
9 tasks
@jeffreypaul15 jeffreypaul15 deleted the example branch July 22, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreypaul15 @nabobalis