Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map transpose #43

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Map transpose #43

merged 2 commits into from
Jul 16, 2021

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jul 16, 2021

It turns out it was wrong to do this... I compared the current example output of sunkit-pyvista to https://docs.sunpy.org/en/stable/generated/gallery/acquiring_data/2011_06_07_sampledata_overview.html#sphx-glr-generated-gallery-acquiring-data-2011-06-07-sampledata-overview-py to check that removing .T is the right thing to do.

Fixes #40

@dstansby dstansby added the No Changelog Entry Needed Skip any changelog checks. label Jul 16, 2021
@dstansby dstansby merged commit a6defd4 into main Jul 16, 2021
@dstansby dstansby deleted the map-transpose branch July 16, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Entry Needed Skip any changelog checks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference in images when running tests
2 participants