Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable log-impl tests #66

Closed
todo bot opened this issue Dec 10, 2018 · 4 comments
Closed

Re-enable log-impl tests #66

todo bot opened this issue Dec 10, 2018 · 4 comments
Assignees
Labels
todo 🗒️ Created by the todo bot

Comments

@todo
Copy link

todo bot commented Dec 10, 2018

https://github.com/roblabla42/KFS/blob/84f52da4950ee96188e38618b55d975a53609284/kernel/src/log_impl/filter/mod.rs#L365-L369


This issue was generated by todo based on a TODO comment in 84f52da when #63 was merged. cc @Orycterope.
@todo todo bot added the todo 🗒️ Created by the todo bot label Dec 10, 2018
@Orycterope
Copy link
Member

Eh whatever, the logger will not be in kernel in the end, so we would be better of ignoring this issue and closing it. Vote 👀 if you agree.

@roblabla
Copy link
Member

We'll still want a kernel logger for debugging purposes.

@Orycterope
Copy link
Member

Yeah, but does it need to be tested ? Will we be using log_impl in the long term ?

@roblabla
Copy link
Member

Why shouldn't it be? And yes, I do think we'll keep using log_impl long-term.

Orycterope referenced this issue in Orycterope/SunriseOS Mar 19, 2019
Orycterope referenced this issue in Orycterope/SunriseOS Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo 🗒️ Created by the todo bot
Projects
None yet
Development

No branches or pull requests

2 participants