-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable log-impl tests #66
Labels
todo 🗒️
Created by the todo bot
Comments
Eh whatever, the logger will not be in kernel in the end, so we would be better of ignoring this issue and closing it. Vote 👀 if you agree. |
We'll still want a kernel logger for debugging purposes. |
Yeah, but does it need to be tested ? Will we be using log_impl in the long term ? |
Why shouldn't it be? And yes, I do think we'll keep using log_impl long-term. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/roblabla42/KFS/blob/84f52da4950ee96188e38618b55d975a53609284/kernel/src/log_impl/filter/mod.rs#L365-L369
This issue was generated by todo based on a
TODO
comment in 84f52da when #63 was merged. cc @Orycterope.The text was updated successfully, but these errors were encountered: